Wrap --base callouts in start skill in BRANCH_DEV conditional#75
Merged
Merged
Conversation
The Case A Step 4 and Case B Step 3 callout paragraphs sat outside the
{{#if BRANCH_DEV}} block wrapping the gh issue develop code fences, so
on trunk-based projects the compiled output leaked a literal
{{BRANCH_DEV}} token and rendered a callout irrelevant to that workflow.
Wrap both callouts in the same conditional and drop the now-redundant
'when BRANCH_DEV is set' clause.
Closes #74
Member
Author
Review SummaryVerdict: APPROVE FindingsNo issues found. Code looks correct and follows project conventions. The two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Case A Step 4 and Case B Step 3 callout paragraphs in
skills/start.mdsat outside the{{#if BRANCH_DEV}}block that wraps thegh issue developcode fences above them. On trunk-based projects (whereBRANCH_DEVis unset) this caused two problems:{{BRANCH_DEV}}token into the rendered callout — flagged downstream as a CRITICAL template bug.This PR wraps both callouts in
{{#if BRANCH_DEV}} … {{/if}}and tightens the wording by dropping the now-redundant "whenBRANCH_DEVis set" clause. All four adapter files (.claude,.cursor,.agents,.gemini) were regenerated via./sync.sh.Test plan
make checkpasses (sync validation clean).claude/commands/start.mdstill renders the callout withgit checkout dev/setup(or bumping the submodule) should remove the literal{{BRANCH_DEV}}from the compiled start skill entirelyCloses #74